----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/586/#review437 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml <https://reviews.apache.org/r/586/#comment851> Did not understand why this change is required? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/586/#comment850> change Table metadata to databse metadata? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/586/#comment849> change Table metadata to partition metadata? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/586/#comment848> change Table metadata to partition metadata? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java <https://reviews.apache.org/r/586/#comment845> Can this be changed to assert statement instead of throwing exception? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java <https://reviews.apache.org/r/586/#comment846> Can this be changed to assert statement instead of throwing exception? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java <https://reviews.apache.org/r/586/#comment847> Can we add the test for group writable also? - Amareshwari On 2011-04-12 22:12:32, Devaraj Das wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/586/ > ----------------------------------------------------------- > > (Updated 2011-04-12 22:12:32) > > > Review request for hive. > > > Summary > ------- > > This is a patch to handle the issue described in HIVE-1943 > > > This addresses bug HIVE-1943. > https://issues.apache.org/jira/browse/HIVE-1943 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 1090038 > http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1090038 > http://svn.apache.org/repos/asf/hive/trunk/metastore/build.xml 1090038 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1090038 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 1090038 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java > 1090038 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java > 1090038 > > http://svn.apache.org/repos/asf/hive/trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java > 1090038 > > http://svn.apache.org/repos/asf/hive/trunk/shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java > 1090038 > > http://svn.apache.org/repos/asf/hive/trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java > 1090038 > > Diff: https://reviews.apache.org/r/586/diff > > > Testing > ------- > > Unit tests added. > > > Thanks, > > Devaraj > >
