[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019119#comment-13019119
 ] 

He Yongqiang commented on HIVE-2090:
------------------------------------

2 nitpick:

1, do not remove the existing  constructor "DropDatabaseDesc(String 
databaseName, boolean ifExists) {"

2, remove TOK_RESTRICT if it has the same meaning with TOK_CASCADE. Use just 
one of them.  "if (null != ast.getFirstChildWithType(TOK_CASCADE))" seems only 
checked TOK_CASCADE. 

3. there is no testcase?

> Add "DROP DATABASE ... FORCE"
> -----------------------------
>
>                 Key: HIVE-2090
>                 URL: https://issues.apache.org/jira/browse/HIVE-2090
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Siying Dong
>            Assignee: Siying Dong
>            Priority: Minor
>         Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch
>
>
> A "DROP DATABASE ... FORCE" will be useful, when we use a database for 
> isolation when doing some tests. Being able to force cleaning up the database 
> will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to