----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/489/#review341 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/489/#comment693> Add comments trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/489/#comment694> You are assuming here that the expression only contains partition columns - add it in the comments for the function trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java <https://reviews.apache.org/r/489/#comment696> Add comments trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java <https://reviews.apache.org/r/489/#comment695> Please add comments - namit On 2011-03-16 16:50:15, Ning Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/489/ > ----------------------------------------------------------- > > (Updated 2011-03-16 16:50:15) > > > Review request for hive. > > > Summary > ------- > > * expose HiveMetaStoreClient.listPartitionsByFilter() to Hive.java so > that PartitionPruner can use that for certain partition predicates. > * only allows {=, AND, OR} in the partition predicates that can be pushed > down to JDO filtering. > > > Diffs > ----- > > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 1081948 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1081948 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/parser/ExpressionTree.java > 1081948 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1081948 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1081948 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 1081948 > trunk/ql/src/test/queries/clientpositive/ppr_pushdown.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/ppr_pushdown2.q PRE-CREATION > trunk/ql/src/test/results/clientpositive/ppr_pushdown.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/ppr_pushdown2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/489/diff > > > Testing > ------- > > > Thanks, > > Ning > >
