[ 
https://issues.apache.org/jira/browse/HIVE-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13008238#comment-13008238
 ] 

Joydeep Sen Sarma commented on HIVE-2052:
-----------------------------------------

small nits:
- setinputpathtocontentsummary is called twice on the same hookcontext object
- we are setting the hook type again and again (can do it once before calling 
postexecute)

should the inputpathtocontentsummary be marked final in the hook and passed 
along with the constructor? (why would we ever change the map to a new one?).

> PostHook and PreHook API to add flag to indicate it is pre or post hook plus 
> cache for content summary
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2052
>                 URL: https://issues.apache.org/jira/browse/HIVE-2052
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Siying Dong
>            Assignee: Siying Dong
>            Priority: Minor
>         Attachments: HIVE-2052.1.patch, HIVE-2052.2.patch
>
>
> This will allow hooks to share some information better and reduce their 
> latency

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to