[
https://issues.apache.org/jira/browse/HIVE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993248#comment-12993248
]
Ning Zhang commented on HIVE-818:
---------------------------------
1) do you need to increase the VERSION number in HiveServer?
Good point. I've changed in the next patch.
2) is it better to put the setupSessionIO() in execute()? If it is already
there, should we remove the one in the constructor? And cleanup the Driver at
the end of execute()?
session IO cannot be cleaned up at the end of execute(). The data is copied
back to the client by fetch* functions, so the client has to do the clean up.
Also sessionIO is better to be set up in the constructors because out and err
can be used by any function (not only execute). The execute() function is just
doing a cleanup work.
3) the len and pos local var in cleanTmpFile is not used.
Will do.
4) maybe not related to this jira: the SessionState in Hive is thread local
object, is it guaranteed that the HiveServerHandler is also thread local, (so
there is a 1-1 match)?
HiveServer constructs a new HiveServerHandler for each worker thread. So for
each CLI remote connection there is a HiveServerHandler, which will create a
thread local SessionState. I've manually tested 100 parallel runs of remote CLI
and they are fine.
> Create a Hive CLI that connects to hive ThriftServer
> ----------------------------------------------------
>
> Key: HIVE-818
> URL: https://issues.apache.org/jira/browse/HIVE-818
> Project: Hive
> Issue Type: New Feature
> Components: Clients, Server Infrastructure
> Reporter: Edward Capriolo
> Assignee: Ning Zhang
> Attachments: HIVE-818.2.patch, HIVE-818.patch, Hive-881_2.patch
>
>
> We should have an alternate CLI that works by interacting with the
> HiveServer, in this way it will be ready when/if we deprecate the current CLI.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
