----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/360/#review170 -----------------------------------------------------------
Hi Mac, thanks for following up on this. I have a couple comments, mainly focused on the need to mention hive.metastore.cache.pinobjtypes by name in the log statements. http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/360/#comment343> I think this LOG message should be moved up a line so that it prints regardless of whether or not objTypes is null, and the message should also mention hive.metastore.cache.pinobjtypes by name, e.g: Setting MetaStore object pin classes with hive.metastore.cache.pinobjtypes="Table,StorageDescriptor,..." http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/360/#comment344> Maybe replace the for loop with StringUtils.join(PINCLASSMAP.keySet(), " ") ? http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/360/#comment345> Please change this to "PersistenceManagerFactory returned null DataStoreCache object. Unable to initialize object pin types defined by hive.metastore.cache.pinobjtypes" - Carl On 2011-01-26 16:49:46, Mac Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/360/ > ----------------------------------------------------------- > > (Updated 2011-01-26 16:49:46) > > > Review request for hive. > > > Summary > ------- > > Review request for HIVE-1931 > > > This addresses bug HIVE-1931. > https://issues.apache.org/jira/browse/HIVE-1931 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 1063913 > > Diff: https://reviews.apache.org/r/360/diff > > > Testing > ------- > > > Thanks, > > Mac > >
