[
https://issues.apache.org/jira/browse/HIVE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981991#action_12981991
]
Paul Yang commented on HIVE-1818:
---------------------------------
Looks pretty good, though I'm not too familiar with MBeans
A few changes:
* Can you print the exception stack if Metrics.init() fails in
HiveMetaStore.init()? See MetastoreUtils for some helper methods
* Metrics.incrementCounter(String, int) - with a new name, it should set the
value to the value of increment, not 1
* doesn't MetricsMBeanImpl.metricsMap need to be synchronized since it could be
hit by multiple threads simultaneously?
* Can you run checkstyle on the new files? I saw issues like
{code}
if (!initialized){ return null; }
{code}
> Call frequency and duration metrics for HiveMetaStore via jmx
> -------------------------------------------------------------
>
> Key: HIVE-1818
> URL: https://issues.apache.org/jira/browse/HIVE-1818
> Project: Hive
> Issue Type: New Feature
> Components: Metastore
> Reporter: Sushanth Sowmyan
> Assignee: Sushanth Sowmyan
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: HIVE-1818-vs-1054860.patch, HIVE-1818.patch
>
>
> As recently brought up in the hive-dev mailing list, it'd be useful if the
> HiveMetaStore had some sort of instrumentation capability so as to measure
> frequency of calls to various calls on the HiveMetaStore and the duration of
> time spent in these calls.
> There are already incrementCounter() and logStartFunction() /
> logStartTableFunction() ,etc calls in HiveMetaStore, and they could be
> refactored/repurposed to make calls that expose JMX MBeans as well. Or, a
> Metrics subsystem could be introduced which made calls to
> incrementCounter()/etc as a refactor.
> It might also be possible to specify a -D parameter that the Metrics
> subsystem could use to determine whether or not to be enabled, and if so, on
> to what port. And once we have the capability to instrument and expose
> MBeans, it might also be possible for other subsystems to also adopt and use
> this system.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
