[ 
https://issues.apache.org/jira/browse/HIVE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978204#action_12978204
 ] 

Carl Steinbach commented on HIVE-1881:
--------------------------------------

The new configuration property "hive.metastore.fs.handler.class" needs to get 
added to hive-default.xml
along with a short description explaining what it does.

The other problem I see is that the MetaStoreFS interface that this patch added 
is incomplete --
it only defines a deleteDir() method. What about createDir(), isDir(), etc? It 
seems like any MetaStore
code that directly references Hadoop's FileSystem class needs to get moved into 
HiveMetaStoreFsImpl.

I don't think this needs to be done right away, but the problem with waiting is 
that any changes to MetaStoreFS
will break classes that implement older versions of that interface. Since 
MetaStoreFS is a public API we
need to get this done before it appears in an official release.




> Add an option to use FsShell to delete dir in warehouse
> -------------------------------------------------------
>
>                 Key: HIVE-1881
>                 URL: https://issues.apache.org/jira/browse/HIVE-1881
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>         Attachments: HIVE-1881.1.patch, HIVE-1881.2.patch, HIVE-1881.3.patch
>
>
> >>@Yongqiang: What's the motivation for doing this?
> This is to work with some internal hacky codes about doing delete. There 
> should be no impact if you use open source hadoop.
> But the idea here is to give users 2 options to do the delete. In Facebook, 
> we have some customized code in FsShell which can control whether the delete 
> should go through trash or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to