Potential risk of resource leaks in Hive
----------------------------------------
Key: HIVE-1884
URL: https://issues.apache.org/jira/browse/HIVE-1884
Project: Hive
Issue Type: Bug
Affects Versions: 0.6.0
Environment: Hive 0.6.0, Hadoop 0.20.1
SUSE Linux Enterprise Server 11 (i586)
Reporter: Mohit Sikri
h3.There are couple of resource leaks.
h4.For example,
In CliDriver.java, Method :- processReader() the buffered reader is not closed.
h3.Also there are risk(s) of resource(s) getting leaked , in such cases we
need to re factor the code to move closing of resources in finally block.
h4. For Example :-
In Throttle.java Method:- checkJobTracker() , the following code snippet
might cause resource leak.
{code}
InputStream in = url.openStream();
in.read(buffer);
in.close();
{code}
Ideally and as per the best coding practices it should be like below
{code}
InputStream in=null;
try {
in = url.openStream();
int numRead = in.read(buffer);
}
finally {
IOUtils.closeStream(in);
}
{code}
Similar cases, were found in ExplainTask.java, DDLTask.java etc.Need to re
factor all such occurrences.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
