[ 
https://issues.apache.org/jira/browse/HIVE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977657#action_12977657
 ] 

Namit Jain commented on HIVE-1840:
----------------------------------

Mostly looks good - some minor comments.

1. The type in prehook and posthook should not be null.
2. The inputs and outputs should be populated - create a database object and 
pass it in Read/WriteEntity.
3. I didn't look carefully, but do the same changes for CREATE/DROP DATABASE 
also if not already done so.

> Support ALTER DATABASE to change database properties
> ----------------------------------------------------
>
>                 Key: HIVE-1840
>                 URL: https://issues.apache.org/jira/browse/HIVE-1840
>             Project: Hive
>          Issue Type: New Feature
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Ning Zhang
>         Attachments: HIVE-1840.patch
>
>
> This is a follow-up to HIVE-1836

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to