[ 
https://issues.apache.org/jira/browse/HIVE-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932168#action_12932168
 ] 

Namit Jain commented on HIVE-1642:
----------------------------------

TaskGraphWalker:

      if(!(nd instanceof Task)){
        throw new SemanticException("Task Graph Walker only walk fro Task 
Graph");
      }

spelling mistake:

        taskListInConditionalTask = ((ConditionalTask) nd).getListTasks();
        for(Task<? extends Serializable> tsk: taskListInConditionalTask){
          List<Task<? extends Serializable>> childTask = tsk.getChildTasks();
          if(childTask != null){
            nextTaskSet.addAll(tsk.getChildTasks());
          }
        }

Maybe I am missing something: dont we need to add listTasks of conditional 
tasks also to the nextTaskSet ?

This is correct - but can you add more comments ??



CommonJoinResolver:
Do we go here even if it is not possible to convert ?
check the size of smallTableSet with total number of tables



MapJoinProcessor:

  public MapJoinOperator generateMapJoniOperator(ParseContext pctx, 
JoinOperator op,

spelling


> Convert join queries to map-join based on size of table/row
> -----------------------------------------------------------
>
>                 Key: HIVE-1642
>                 URL: https://issues.apache.org/jira/browse/HIVE-1642
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Liyin Tang
>             Fix For: 0.7.0
>
>         Attachments: hive_1642_1.patch
>
>
> Based on the number of rows and size of each table, Hive should automatically 
> be able to convert a join into map-join.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to