----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53/#review31 -----------------------------------------------------------
Ship it! +1 Looks good. Will test/commit. - Paul On 2010-11-08 18:36:25, John Sichi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53/ > ----------------------------------------------------------- > > (Updated 2010-11-08 18:36:25) > > > Review request for hive. > > > Summary > ------- > > Review request from jvs. > > > This addresses bug HIVE-1771. > https://issues.apache.org/jira/browse/HIVE-1771 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java > 1032795 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/udf_round.q > 1032795 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/udf_round.q.out > 1032795 > > Diff: https://reviews.apache.org/r/53/diff > > > Testing > ------- > > > Thanks, > > John > >