[
https://issues.apache.org/jira/browse/HIVE-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922443#action_12922443
]
Andrew Ryan commented on HIVE-1731:
-----------------------------------
I am not a Hive developer, only a Hive user, and not a power user either.
I took a look at what I think are the error messages:
http://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java
and here are my suggestions:
1) Always have error messages start with a capital letter. Some do, some don't.
2) Always make SQL keywords ALL CAPS in error messages. Not only is it helpful,
but there are really potentially ambiguous cases. For example:
"Create table as select command" could have very different interpretation than
"CREATE TABLE AS SELECT command" in some contexts.
3) Be consistent about case, and use capitalization to denote proper nouns or
the beginning of sentences only. For example:
NO_PARTITION_PREDICATE("No Partition Predicate Found")
could probably be:
NO_PARTITION_PREDICATE("No partition predicate found"),
and both styles are mixed in the error messages, which is worse. At least if
they were all one way or all the other way it would be easier to figure out.
> Improve miscellaneous error messages
> ------------------------------------
>
> Key: HIVE-1731
> URL: https://issues.apache.org/jira/browse/HIVE-1731
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: John Sichi
> Fix For: 0.7.0
>
>
> This is a place for accumulating error message improvements so that we can
> update a bunch in batch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
