[ 
https://issues.apache.org/jira/browse/HIVE-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920104#action_12920104
 ] 

Ning Zhang commented on HIVE-1669:
----------------------------------

Thiruvel, changes look good in general. Some minor comments:
 1) can you expand 'import java.util.*' with the class names used in the file, 
just to make the coding style consistent.
 2) can you run the full test with overwrite option: 'ant test -Doverwrite 
...'. There should be a lot of .out file changes and upload the full patch? You 
may need to run both -Dhadoop.version=0.20.0 and -Dhadoop.version=0.17.2.1


> non-deterministic display of storage parameter in test
> ------------------------------------------------------
>
>                 Key: HIVE-1669
>                 URL: https://issues.apache.org/jira/browse/HIVE-1669
>             Project: Hadoop Hive
>          Issue Type: Sub-task
>            Reporter: Ning Zhang
>            Assignee: Thiruvel Thirumoolan
>         Attachments: HIVE-1669.patch
>
>
> With the change to beautify the 'desc extended table', the storage parameters 
> are displayed in non-deterministic manner (since its implementation is 
> HashMap). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to