Got it, thanks. Yes these directories are intentionally retained. Best Wishes, Tom
On 2024/05/17 01:37:15 Zhang Yonglun wrote: > The actual situation is not like this, there is no.gitignore in these > directories. Moreover, there should be no.git* files in the released > source code package. If these directories are intentionally retained > for script execution, then they can be kept. > > Best Regards, > Zhang Yonglun > > Chao Gong <gongc...@apache.org> 于2024年5月16日周四 23:56写道： > > > > Hi Yonglun, > > > > Thanks for your careful verification, i'll fix these, then start the new > > vote process and mobilize the PPMC to review it. > > > > Question about 5, > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-iotdb/dbdata/iotdbdata > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-iotdb/dbdata/mysqldata > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-tdengine/dbdata/mysqldata > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-tdengine/dbdata/taosdata > > > > the directories have file `.gitignore`, is this allowed? The script > > requires a directory like this. > > > > > > Best wishes, > > Tom > > > > On 2024/05/16 04:08:02 Zhang Yonglun wrote: > > > -1 binding > > > > > > 1. The folder name after extracting the *-bin.tar.gz archive is > > > inconsistent with the archive name, it does not include '-bin'. > > > > > > 2. The -bin/LICENSE file content is incorrect, it does not include the > > > list of licenses on which this binary depends. > > > (-bin/licenses/backend and *-bin/licenses/frontend contain LICENSEs, > > > but they should not be placed in these locations) > > > > > > 3. The *-bin/NOTICE file does not include the NOTICE files of the > > > Apache projects on which it depends. For example: > > > poi-ooxml-4.1.1 > > > rocketmq-acl-4.9.4 > > > arrow-format-10.0.1 > > > > > > 4. The licenses directory of both > > > apache-hertzbeat-collector-1.6.0-incubating and > > > apache-hertzbeat-1.6.0-incubating are identical. Is this because their > > > dependencies are exactly the same? This seems unlikely. Licenses that > > > are not depended upon should not be included in the project's > > > licenses. > > > > > > 5. There are empty directories in the source code archive > > > apache-hertzbeat-1.6.0-incubating-src: > > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-iotdb/dbdata/iotdbdata > > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-iotdb/dbdata/mysqldata > > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-tdengine/dbdata/mysqldata > > > apache-hertzbeat-1.6.0-incubating-src/script/docker-compose/hertzbeat-mysql-tdengine/dbdata/taosdata > > > > > > Additionally, the votes from the PPMC members are insufficient, with > > > only one valid vote. Please recognize the importance of the release > > > process and mobilize the PPMC to review it, so they can gain > > > experience for their future roles as release managers. > > > > > > Best Regards, > > > Zhang Yonglun > > > > > > Chao Gong <gongc...@apache.org> 于2024年5月14日周二 13:20写道： > > > > > > > > Hello HertzBeat Community: > > > > > > > > This is a call for vote to release our first Apache HertzBeat > > > > (incubating) > > > > version release-1.6.0-RC1. > > > > > > > > Apache HertzBeat - a real-time monitoring system with agentless, > > > > performance cluster, prometheus-compatible, custom monitoring and status > > > > page building capabilities. > > > > > > > > Release notes: > > > > https://github.com/apache/hertzbeat/releases/tag/v1.6.0-rc1 > > > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/incubator/hertzbeat/1.6.0-RC1/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/hertzbeat/releases/tag/v1.6.0-rc1 > > > > > > > > The artifacts signed with PGP key [33545C76], corresponding to [ > > > > gongc...@apache.org], that can be found in keys file: > > > > https://downloads.apache.org/incubator/hertzbeat/KEYS > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > > > number > > > > of votes are reached. > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > *Valid check is a requirement for a vote. * Checklist for reference: > > > > > > > > [ ] Download HertzBeat are valid. > > > > [ ] Checksums and PGP signatures are valid. > > > > [ ] Source code distributions have correct names matching the current > > > > release. > > > > [ ] LICENSE and NOTICE files are correct for each HertzBeat repo. > > > > [ ] All files have license headers if necessary. > > > > [ ] No compiled archives bundled in source archive. > > > > [ ] Can compile from source. > > > > > > > > More detail checklist please refer: > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > Steps to validate the release，Please refer to: > > > > https://hertzbeat.apache.org/docs/community/how_to_verify_release > > > > > > > > How to Build: > > > > https://hertzbeat.apache.org/docs/community/development/#build-hertzbeat-binary-package > > > > > > > > Thanks! > > > > Tom. > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@hertzbeat.apache.org > > > For additional commands, e-mail: dev-h...@hertzbeat.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@hertzbeat.apache.org > > For additional commands, e-mail: dev-h...@hertzbeat.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hertzbeat.apache.org > For additional commands, e-mail: dev-h...@hertzbeat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hertzbeat.apache.org For additional commands, e-mail: dev-h...@hertzbeat.apache.org
