arturobernalg commented on PR #958: URL: https://github.com/apache/httpcomponents-client/pull/958#issuecomment-7061654571
This does not address the actual problem. The new check only prevents storing certain responses, while cache lookup still happens before the effective Cookie headers are available. Reproduced with real HTTP clients in both classic and async: a cached anonymous response with `Vary: Cookie` is incorrectly reused for subsequent requests with different cookies, violating [RFC 9111 ยง4.1](https://www.rfc-editor.org/rfc/rfc9111.html#section-4.1). The new guard also prevents legitimate caching of responses varying on context-generated cookies. I think we need to reconsider the execution chain and ensure cache lookup and storage operate on the effective request headers, rather than adding another guard to the caching layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
