ok2c commented on PR #925: URL: https://github.com/apache/httpcomponents-client/pull/925#issuecomment-6708904916
> The challenge type is left out of `equals`/`hashCode`/`match`, since including it breaks exact-scope lookups in existing providers @Hsnmohd These two scopes being equal, does not feel right. I think challenge type must be included in `#equals`, `#hashCode` and `#match`. If that breaks existing providers we need to figure out how to un-break them. ``` final AuthScope authScope1 = new AuthScope(host, getRealm(), getName(), ChallengeType.TARGET); final AuthScope authScope2 = new AuthScope(host, getRealm(), getName(), ChallengeType.PROXY); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
