rursprung commented on PR #906:
URL:
https://github.com/apache/httpcomponents-client/pull/906#issuecomment-6471045349
Thanks! I have addressed the points:
- **Caching builders:** I no longer claim caching support in the PR
description. I kept the `CONTENT_LENGTH` wiring in the caching
`enable(...)` overloads so that it matches `BASIC` and `IO` and starts
working once the `CACHING` ordering is fixed. Integration tests for the
caching builders can come with that fix. If you prefer, I can remove the
caching wiring from this PR instead.
- **HTTP/2:** Documented in the Javadoc of `AsyncContentLengthExec` and in
the PR description: HttpCore reports the response entity length as
unknown over HTTP/2, so no response length is recorded there.
- **"Uncompressed":** The Javadoc and commit message no longer say the
value is always uncompressed. It is the declared entity length as the
application sees it. It is uncompressed when the client handles content
coding, and it is the encoded length if the application sends an already
encoded entity or if content compression is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
