tdcornish commented on PR #726: URL: https://github.com/apache/httpcomponents-core/pull/726#issuecomment-6452284338
@ok2c You are correct, the lock is not needed and I've updated the PR accordingly. `SSLIOSession` already holds the lock when it calls `getEventMask`, so the TLS case is covered, and the reproducer passes. Technically close() sets CLOSED before it cancels the key, so `onIOEvent` can still occasionally pass the check and hit a cancelled key. `InternalChannel#handleIOEvent `already handles that, so it's harmless in practice -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
