ok2c commented on code in PR #880:
URL:
https://github.com/apache/httpcomponents-client/pull/880#discussion_r4182414935
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/H2AsyncClientBuilder.java:
##########
@@ -247,6 +251,18 @@ public final H2AsyncClientBuilder setIOReactorConfig(final
IOReactorConfig ioRea
return this;
}
+ /**
+ * Sets the factory used by the I/O reactor to create socket channels for
+ * outgoing connections.
+ *
+ * @return this instance.
+ * @since 5.7
+ */
Review Comment:
@arturobernalg Should also be `@Internal`, should it not?
##########
httpclient5/src/main/java/org/apache/hc/client5/http/io/DetachedSocketFactory.java:
##########
@@ -32,13 +32,13 @@
import java.net.Socket;
import org.apache.hc.core5.annotation.Contract;
-import org.apache.hc.core5.annotation.Internal;
import org.apache.hc.core5.annotation.ThreadingBehavior;
/**
+ * Factory for detached sockets used for outgoing classic connections.
+ *
* @since 5.4
*/
-@Internal
Review Comment:
@arturobernalg Do you want to make this one public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
