ok2c commented on PR #693: URL: https://github.com/apache/httpcomponents-core/pull/693#issuecomment-5645479987
@arturobernalg Very good. Out of curiosity, how much of this change-set was AI generated? It is perfectly fine. It just looks completely different and that makes me think those classes got generated. Ideally I would like the `#hashCode` and `#equals` methods of the new classes to be consistent with the rest of code base. As well argument validation should ideally be done with `Args` methods. This is not a must. But consistency would be nice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
