ok2c commented on code in PR #870:
URL:
https://github.com/apache/httpcomponents-client/pull/870#discussion_r3782617841
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/ResponseCachingPolicy.java:
##########
Review Comment:
@arturobernalg Damn it. This is wrong. In fact the entire logic is based on
the protocol version _hint_ and not t he real transport version. It is broken
and wrong.
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/ResponseCachingPolicy.java:
##########
@@ -105,6 +105,7 @@ public boolean isResponseCacheable(final
RequestCacheControl requestCacheControl
}
return false;
}
+ // HTTP/1.0 response caching is deprecated and will be rejected here
in a future release.
Review Comment:
@arturobernalg Let's drop this comment altogether. I am going to remove the
request version check from this class shortly/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
