ok2c commented on code in PR #859:
URL:
https://github.com/apache/httpcomponents-client/pull/859#discussion_r3643834761
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/cache/HttpCacheEntryFactory.java:
##########
@@ -152,6 +153,27 @@ public HttpCacheEntry create(final Instant requestInstant,
final HttpRequest request,
final HttpResponse response,
final Resource resource) {
+ return create(requestInstant, responseInstant, host, request, null,
response, resource);
+ }
+
+ /**
+ * Create a new {@link HttpCacheEntry} with the given request content and
{@link Resource}.
+ *
+ * @param requestInstant Date/time when the request was made (Used for
age calculations)
+ * @param responseInstant Date/time that the response came back (Used for
age calculations)
+ * @param host Target host
+ * @param request Original client request (a deep copy of this
object is made)
+ * @param requestContent Content enclosed in the original client request
or {@code null}
+ * @param response Origin response (a deep copy of this object is
made)
+ * @param resource Resource representing origin response body
+ */
Review Comment:
@hunghhdev Please add `@since 5.7` tags to all new methods. Looks very good
otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
