rschmitt commented on code in PR #814:
URL:
https://github.com/apache/httpcomponents-client/pull/814#discussion_r2970200555
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/InternalHttpAsyncExecRuntime.java:
##########
@@ -327,6 +330,54 @@ private AsyncClientExchangeHandler guard(final
AsyncClientExchangeHandler handle
return new ReleasingAsyncClientExchangeHandler(handler,
this::releaseSlot);
}
+ private Cancellable doExecute(
Review Comment:
Ideally, preparatory refactorings like this method extraction would be done
in separate commits for ease of review (they can still be submitted in a single
PR and squashed before merging)
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/InternalHttpAsyncExecRuntime.java:
##########
@@ -327,6 +330,54 @@ private AsyncClientExchangeHandler guard(final
AsyncClientExchangeHandler handle
return new ReleasingAsyncClientExchangeHandler(handler,
this::releaseSlot);
}
+ private Cancellable doExecute(
+ final String id,
+ final AsyncConnectionEndpoint endpoint,
+ final AsyncClientExchangeHandler exchangeHandler,
+ final HttpClientContext context) {
+ final RequestConfig requestConfig =
context.getRequestConfigOrDefault();
+ final Timeout responseTimeout = requestConfig.getResponseTimeout();
+ final EndpointInfo endpointInfo = endpoint.getInfo();
+ final ProtocolVersion version = endpointInfo != null ?
endpointInfo.getProtocol() : null;
+ final boolean supportsStreams = version != null &&
version.greaterEquals(HttpVersion.HTTP_2);
Review Comment:
I suggest `supportsMultiplexing` or just `isH2`. "Stream" is an overloaded
term and to me mainly connotes `InputStream`s and the like, i.e. streaming in
contrast to buffering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
