arturobernalg commented on code in PR #645:
URL:
https://github.com/apache/httpcomponents-core/pull/645#discussion_r2869668811
##########
httpcore5/src/main/java/org/apache/hc/core5/pool/LaxConnPool.java:
##########
@@ -98,6 +113,8 @@ public LaxConnPool(
this.routeToPool = new ConcurrentHashMap<>();
this.isShutDown = new AtomicBoolean();
this.defaultMaxPerRoute = defaultMaxPerRoute;
+ this.clock = Args.notNull(clock, "clock");
+ this.currentTimeSupplier = this.clock::millis;
Review Comment:
> Why do we need `currentTimeSupplier` and `clock` both? Either of those
should be enough, should it not?
I wanted to keep the clock-injection patch low-risk and avoid API churn in
PoolEntry, so I kept Supplier<Long> there and passed clock::millis from the
pool. I just remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
