ok2c commented on code in PR #636:
URL:
https://github.com/apache/httpcomponents-core/pull/636#discussion_r2842692903
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -960,6 +965,10 @@ private void consumeFrame(final RawFrame frame) throws
HttpException, IOExceptio
if (payload != null && payload.hasRemaining()) {
throw new
H2ConnectionException(H2Error.FRAME_SIZE_ERROR, "Invalid SETTINGS ACK payload");
}
+ // RFC 9113, Section 3.4 / 6.5: the first peer SETTINGS
cannot be ACK.
Review Comment:
@arturobernalg I would avoid references in specific RFCs or their sections
in our source code. If the RFC 9113 gets superseded by a newer revision we
would have to go through our code and update all these references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
