ok2c commented on PR #606: URL: https://github.com/apache/httpcomponents-core/pull/606#issuecomment-3871092692
@arturobernalg I like the fact that API changes are small, but I find the implementation too complex and overwrought: The process should be quite simple: * on timeout shut down immediately if the connection has not been fully initialized, SETTINGS handshake has not completed or the keep-alive has not been turned on * otherwise set timeout to something like 1 second and send ping * if ping comes back restore the original timeout * if a timeout event fires again, shut down the connection and go home -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
