ok2c commented on code in PR #591:
URL:
https://github.com/apache/httpcomponents-core/pull/591#discussion_r2649193554
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java:
##########
@@ -522,7 +523,7 @@ public HttpAsyncServer create() {
final ServerH2StreamMultiplexerFactory http2StreamHandlerFactory = new
ServerH2StreamMultiplexerFactory(
httpProcessor != null ? httpProcessor : H2Processors.server(),
handlerFactory,
- h2Config != null ? h2Config : H2Config.DEFAULT,
+ h2Config != null ? h2Config :
H2Config.custom().setPushEnabled(false).build(),
Review Comment:
@CoolTomatos Could you make a static private variable out of it? Looks good
otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
