rschmitt commented on PR #581: URL: https://github.com/apache/httpcomponents-core/pull/581#issuecomment-3666659456
> @rschmitt I’ve added an async core HTTP/2 socket-timeout test in httpcore5-testing (`AsyncH2SocketTimeoutCoreTest`) that mirrors the client-side `TestAsyncSocketTimeout` behaviour. It verifies that a per-request timeout over HTTP/2 results in HttpStreamResetException, so I believe this covers the contract you were asking for – let me know if you had something different in mind. Ideally I'd like to see contract testing, i.e. the same test cases running for HTTP, HTTPS, h2, and h2c. This ensures that the high-level API behaves consistently across the various implementations; it's also a very effective way of asserting that the various config options are being propagated and applied correctly throughout the client's internals. This is most effectively done through tests in `httpclient5` (which has the issue that Oleg pointed out, _unless_ you are backfilling a feature into existing APIs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
