garydgregory commented on code in PR #641: URL: https://github.com/apache/httpcomponents-client/pull/641#discussion_r2126850077
########## pom.xml: ########## @@ -192,6 +192,12 @@ <artifactId>junit-jupiter</artifactId> <version>${testcontainers.version}</version> </dependency> + <dependency> + <groupId>commons-io</groupId> + <artifactId>commons-io</artifactId> + <version>2.19.0</version> + <scope>test</scope> Review Comment: Thank you for the review @ok2c , fixed, squashed, and pushed. ########## httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java: ########## @@ -215,6 +216,32 @@ public MultipartEntityBuilder addBinaryBody( return addPart(name, new FileBody(file, contentType, filename)); } + /** + * Adds body with contents from the given source Path. + * + * @param name The part name. + * @param path The source path. + * @return {@code this} instance. + * @since 5.5.1 Review Comment: Fixed, squashed, and pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org