rschmitt commented on PR #636: URL: https://github.com/apache/httpcomponents-client/pull/636#issuecomment-2906055216
> I'm generally not a fan of Maven Wrapper because it often goes stale and adds unnecessary complexity for little benefit. I'm surprised by this. The Maven wrapper is quite convenient. For instance, my Linux desktop doesn't actually have a version of Maven recent enough to build HttpComponents, and by far the easiest way to _obtain_ one was to set up the wrapper. I also invoke the wrapper from https://github.com/apache/httpcomponents-client/pull/635 to help ensure that the example runner just works. I think it would be a good idea in principle to use the Maven wrapper in the GitHub workflows, but it's not a huge difference either way since Maven is fairly stable. (With a Gradle project, by contrast, using the wrapper would be absolutely non-negotiable.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
