ok2c commented on code in PR #566:
URL:
https://github.com/apache/httpcomponents-client/pull/566#discussion_r2021404040
##########
httpclient5/src/main/java/org/apache/hc/client5/http/psl/PublicSuffixMatcher.java:
##########
@@ -149,24 +148,30 @@ public String getDomainRoot(final String domain, final
DomainType expectedType)
}
final DomainType domainRule = findEntry(rules, key);
if (match(domainRule, expectedType)) {
- if (domainRule == DomainType.PRIVATE) {
Review Comment:
@massdosage I did a bad job reviewing your changes so the fault is mine and
mine only. The specification actually _does_ explicitly state that
```
While some applications, such as browsers when considering cookie-setting,
treat all entries the same, other applications may wish to treat ICANN domains
and PRIVATE domains differently
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
