michael-o commented on code in PR #619:
URL:
https://github.com/apache/httpcomponents-client/pull/619#discussion_r1979881919
##########
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/MultipartEntityBuilder.java:
##########
@@ -204,6 +217,20 @@ public MultipartEntityBuilder addBinaryBody(final String
name, final InputStream
return addBinaryBody(name, stream, ContentType.DEFAULT_BINARY, null);
}
+ /**
+ * Returns the fixed default boundary value.
+ */
+ private String getFixedBoundary() {
+ return BOUNDARY_PREFIX + "7k9p2m4x8n5j3q6t1r0vwyzabcdefghi";
+ }
+
+ /**
+ * Generates a random boundary using UUID.
+ */
+ private String getRandomBoundary() {
+ return BOUNDARY_PREFIX + UUID.randomUUID();
Review Comment:
I must admit that the prefix is redundant if you use UUID, no? It just
increates the body...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
