ok2c commented on code in PR #618:
URL:
https://github.com/apache/httpcomponents-client/pull/618#discussion_r1973659740
##########
httpclient5/src/main/java/org/apache/hc/client5/http/entity/mime/FormBodyPartBuilder.java:
##########
@@ -47,22 +50,52 @@ public class FormBodyPartBuilder {
private ContentBody body;
private final Header header;
+ /**
+ * The multipart mode determining how filenames are encoded in the {@code
Content-Disposition}
+ * header, defaults to {@link HttpMultipartMode#STRICT}.
+ *
+ * @since 5.5
+ */
+ private HttpMultipartMode mode;
+
+ /**
+ * Reusable encoder for ISO-8859-1 charset checks, improving performance
by avoiding
+ * repeated instance creation.
+ */
+ private final CharsetEncoder iso8859_1Encoder =
StandardCharsets.ISO_8859_1.newEncoder();
Review Comment:
@arturobernalg I would instantiate this attribute lazily. It does not need
to be final. Looks good overall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
