ok2c commented on code in PR #508:
URL:
https://github.com/apache/httpcomponents-core/pull/508#discussion_r1860464715
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/HttpRequestExecutor.java:
##########
@@ -212,7 +213,7 @@ public ClassicHttpResponse execute(
return response;
} catch (final HttpException | IOException | RuntimeException ex) {
- Closer.closeQuietly(conn);
Review Comment:
@ooeunz Let's do better. Could you please do `CloseMode.IMMEDIATE` for
`IOException`s and `RuntimeException`s and regular close for `SSLException`s
and `HttpException`s?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
