arturobernalg commented on PR #498: URL: https://github.com/apache/httpcomponents-core/pull/498#issuecomment-2423123516
> @arturobernalg > > 1. `@since` tag should be 5.4 > > 2. Now we have similar check done twice, once in the new interceptors and another one in `H2RequestConformance`. I think these new checks should be moved to the existing interceptors. @ok2c I’ve made the changes as you suggested. I’ve removed the new TE checks for HTTP/2 since they were redundant with the existing validations in H2RequestConformance. Apologies for the oversight on my part, as I had previously validated your PR with these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
