garydgregory commented on PR #588: URL: https://github.com/apache/httpcomponents-client/pull/588#issuecomment-2408654045
I'm still skeptical, this looks to me like 2 bugs in JApiCmp 😞 - The change from non-`final` to `final` breaks subclasses since the containing class is public and non-final. - The return type change After I run: ``` mvn -DskipTests -pl httpclient5 -Dhc.japicmp.version=0.23.0 ``` JApiCmp thinks the method is "NEW" and "METHOD_ADDED_TO_PUBLIC_CLASS". Instead, I think it should report "METHOD_RETURN_TYPE_CHANGED". It should also note the change from non-`final` to `final` but it doesn't since it considers the method new, which according to the JLS it is. There's been a few bugs in this area: https://github.com/siom79/japicmp/issues?q=is%3Aissue++return+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
