Claus Ibsen created HTTPCLIENT-2340:
---------------------------------------

             Summary: org.apache.hc.core5.net.URIBuilder - Allow to configure 
plusAsBlank
                 Key: HTTPCLIENT-2340
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2340
             Project: HttpComponents HttpClient
          Issue Type: Improvement
          Components: HttpClient (classic)
    Affects Versions: 5.2.3
            Reporter: Claus Ibsen


When upgrading from Http Client v4 to v5 then the URIBuilder has changed a 
default value for the plusAsBlank option.

 

In v4 the default is true

 

org.apache.http.client.utils.URLEncodedUtils.decodeFormFields()
~~~
return urlDecode(content, charset != null ? charset : Consts.UTF_8, true);
~~~

In v5 the default is changed to false

org.apache.hc.core5.net.URIBuilder.digestURI()
~~~
this.queryParams = parseQuery(uri.getRawQuery(), charset, false);
~~~

 

I wonder if the URIBuilder could have some kind of flag that can be set to set 
whether to use true or false.

 

import org.apache.hc.core5.http.NameValuePair;
import org.apache.hc.core5.http.message.BasicNameValuePair;
import org.apache.hc.core5.net.URIBuilder;

 

        URIBuilder uriBuilder;
        uriBuilder = new 
URIBuilder("[http://dummy/demo+demo?sample=sample+sample]";);
        LOG.info("uri="+uriBuilder.toString());
        List<NameValuePair> queryParameters = uriBuilder.getQueryParams();
        queryParameters.add(new BasicNameValuePair("Greeting", "hello"));
        uriBuilder.setParameters(queryParameters);
        LOG.info("uri="+uriBuilder.toString());



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to