otavioprado commented on PR #564: URL: https://github.com/apache/httpcomponents-client/pull/564#issuecomment-2266676057
> @otavioprado Few minor things > > 1. Generally we do not add new features (and this is technically a new feature) to stable branches. Would you mind changing the target branch to `master` (5.4)? > 2. Please change `@since` tag to `5.4` > 3. Test methods should have package visibility for consistency with existing test cases Hi @ok2c, I've addressed your comments and reopened the pull request with the necessary changes. The new PR is targeting the master branch as requested, and you can find it here: [#565](https://github.com/apache/httpcomponents-client/pull/565). Thank you for your feedback, and please let me know if there are any additional adjustments needed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
