ok2c commented on code in PR #553:
URL:
https://github.com/apache/httpcomponents-client/pull/553#discussion_r1506574701
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java:
##########
@@ -134,7 +135,27 @@
* exclusive and may not apply when building {@link CloseableHttpClient}
* instances.
* </p>
- *
+ * The following are the default implementations per component
Review Comment:
@kwin In all honesty next time I am going to touch `HttpClientBuilder` I am
not sure I will get around to updating this table. It will ultimately rot and
will cause more harm than good.
In any case If you want this change-set committed, please at the very least
update `HttpAsyncClientBuilder`, `CachingHttpClientBuilder` and
`CachingHttpAsyncClientBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
