[ https://issues.apache.org/jira/browse/HTTPCLIENT-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821745#comment-17821745 ]
Konrad Windszus commented on HTTPCLIENT-2321: --------------------------------------------- Probably listing for each {{setter}} and in the class overview at https://hc.apache.org/httpcomponents-client-5.3.x/current/httpclient5/apidocs/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.html what the default implementation is for each aspect would help a lot (this does not only affect the connection manager). > Clarify the default connection manager being used > ------------------------------------------------- > > Key: HTTPCLIENT-2321 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2321 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: Documentation > Affects Versions: 5.4-alpha1 > Reporter: Konrad Windszus > Priority: Major > > Neither from reading > https://hc.apache.org/httpcomponents-client-4.5.x/current/tutorial/html/connmgmt.html > nor from the javadocs at either > # > https://hc.apache.org/httpcomponents-client-5.3.x/current/httpclient5/apidocs/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.html, > # > https://hc.apache.org/httpcomponents-client-5.3.x/current/httpclient5/apidocs/org/apache/hc/client5/http/io/HttpClientConnectionManager.html > or > # > https://hc.apache.org/httpcomponents-client-5.3.x/current/httpclient5/apidocs/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.html > it is clear that the {{PoolingHttpClientConnectionManager}} is used by > default if no other connection manager is set explicitly > (https://github.com/apache/httpcomponents-client/blob/f2b9a374d817ee630a2efe706546ba4f1e5a5ac4/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java#L754). > I was always assuming that due to the [KISS > principle|https://en.wikipedia.org/wiki/KISS_principle] the one named > {{BasicHttpClientConnectionManager}} would be the default. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org