ok2c commented on code in PR #511:
URL:
https://github.com/apache/httpcomponents-client/pull/511#discussion_r1413038946
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/DigestScheme.java:
##########
@@ -314,20 +315,34 @@ private String createDigestResponse(final HttpRequest
request) throws Authentica
a1 = null;
a2 = null;
+
+
+ // Extract username and username*
+ String username = credentials.getUserName();
+ final String usernameStar = paramMap.get("username*");
Review Comment:
@arturobernalg This looks wrong. The server is not supposed to be sending us
`username*` i nthe auth challenge, or at any rate, we should not be using it.
We should only be using the username provided by `CredentialsProvider`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
