ok2c commented on code in PR #496:
URL:
https://github.com/apache/httpcomponents-client/pull/496#discussion_r1369850547
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/ResponseCachingPolicy.java:
##########
@@ -258,7 +253,7 @@ protected boolean isExplicitlyNonCacheable(final
ResponseCacheControl cacheContr
}
protected boolean isExplicitlyCacheable(final ResponseCacheControl
cacheControl, final HttpResponse response) {
Review Comment:
> We're calling `isExplicitlyCacheable` twice within the
`isResponseCacheable` method. Maybe we could storing its result in a variable
and reusing it.
@arturobernalg True. However, It is relatively cheap and the first
invocation gets executed conditionally. I think It is not worth the ugliness of
having an extra parameter to pass around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
