ok2c commented on code in PR #497:
URL:
https://github.com/apache/httpcomponents-client/pull/497#discussion_r1369840110
##########
httpclient5/src/main/java/org/apache/hc/client5/http/protocol/RequestIfRange.java:
##########
@@ -121,36 +113,21 @@ public void process(final HttpRequest request, final
EntityDetails entity, final
throw new ProtocolException("'If-Range' header must not contain a
weak entity tag.");
}
- final Header dateHeader = request.getFirstHeader(HttpHeaders.DATE);
+ final Instant dateHeader = DateUtils.parseStandardDate(request,
HttpHeaders.DATE);
if (dateHeader == null) {
return;
}
+ final Instant lastModifiedHeader =
DateUtils.parseStandardDate(request, HttpHeaders.LAST_MODIFIED);
Review Comment:
@arturobernalg `lastModifiedHeader` is likely not the best name now.
`lastModified`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
