ok2c commented on code in PR #492:
URL:
https://github.com/apache/httpcomponents-client/pull/492#discussion_r1349741733
##########
httpclient5/src/test/java/org/apache/hc/client5/http/examples/AsyncClientCustomSSL.java:
##########
@@ -59,6 +59,11 @@ public class AsyncClientCustomSSL {
public static void main(final String[] args) throws Exception {
// Trust standard CA and those trusted by our custom strategy
final SSLContext sslContext = SSLContexts.custom()
+ // Specify a custom TrustStrategy
Review Comment:
> So would the following comment content be ok for you (though it is a bit
verbose)?
@Marcono1234 I disagree with your emphasis on the use of trust stores as
somehow being the preferred method. It is not any more secure, it is just
simpler, that is all. I personally would not phrase it this way, but I can live
with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
