Marcono1234 opened a new pull request, #490: URL: https://github.com/apache/httpcomponents-client/pull/490
Tries to improve the documentation of `TrustAllStrategy` and `TrustSelfSignedStrategy` by mentioning their security implications and suggesting more secure alternatives. For `TrustSelfSignedStrategy` it also documents what exactly the strategy does. Otherwise without looking at the implementation details users might erroneously think it is always necessary to use `TrustSelfSignedStrategy` when using self-signed certificates (even if they are also in the truststore), which is not the case. Any feedback is appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org