arturobernalg commented on PR #489: URL: https://github.com/apache/httpcomponents-client/pull/489#issuecomment-1739847709
> @arturobernalg The decision whether or not a request should be retried based on the response status is delegated to the `HttpRequestRetryStrategy`. The default implementation presently retries requests in case of 429 and 503 and nothing else. Requests with a 403 response never get retried by default. One however can still use a custom implementation of the strategy to make the protocol layer to retry requests differently. This is how we allow for non-standard or deviant or custom behaviors without toggles and nonsense like that. Your change-set would make it impossible to retry requests with a 403 response even if the caller intentionally would like to test the behavior of the opposite endpoint. One would need to replace the entire request interceptor in such a case instead of just providing a custom retry strategy. Is this reasonable? @ok2c You're completely right. I overlooked the flexibility regarding the http default codes provided by HttpRequestRetryStrategy. That was my mistake, and I see now how my changes could limit customization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
