arturobernalg commented on code in PR #431:
URL:
https://github.com/apache/httpcomponents-core/pull/431#discussion_r1334759075
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java:
##########
@@ -271,7 +271,7 @@ public void terminateRequest(final ClassicHttpRequest
request) throws HttpExcept
if (entity == null) {
return;
}
- final Iterator<String> ti = new
BasicTokenIterator(request.headerIterator(HttpHeaders.CONNECTION));
+ final Iterator<String> ti = MessageSupport.iterateTokens(request,
HttpHeaders.CONNECTION);
Review Comment:
Shouldn't be `it`??
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/DefaultConnectionReuseStrategy.java:
##########
@@ -81,7 +81,7 @@ public boolean keepAlive(
Args.notNull(response, "HTTP response");
if (request != null) {
- final Iterator<String> ti = new
BasicTokenIterator(request.headerIterator(HttpHeaders.CONNECTION));
+ final Iterator<String> ti = MessageSupport.iterateTokens(request,
HttpHeaders.CONNECTION);
Review Comment:
Shouldn't be `it`??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
