ok2c commented on code in PR #484:
URL:
https://github.com/apache/httpcomponents-client/pull/484#discussion_r1330654678
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheConfig.java:
##########
@@ -257,11 +232,11 @@ public int getMaxUpdateRetries(){
}
/**
- * Returns whether 303 caching is enabled.
- * @return {@code true} if it is enabled.
+ * @deprecated No longer applicable. Do not use.
*/
+ @Deprecated
public boolean is303CachingEnabled() {
- return allow303Caching;
+ return true;
Review Comment:
@arturobernalg The cache protocol layer will now be treating 303 responses
as potentially cacheable by default. This is why I thought the deprecated
method should also return `true`. Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
