[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726926#comment-17726926
 ] 

Oleg Kalnichevski edited comment on HTTPCLIENT-2277 at 9/18/23 11:30 AM:
-------------------------------------------------------------------------

> Under our existing system architecture, we have yet to implement the Vary 
> header validation as specified in these requirements

[~arturobernalg] -I have an unpleasant suspicion that that our entire internal 
cache structure is wrong. Presently it is a simple map of response objects 
keyed by the request URI and Vary headers. I suspect instead it should be a map 
of collections of request / response variants keyed by the request method and 
the request URI. It looks like we are looking at the complete redesign of the 
cache storage APIs and rewrite of the cache storage backends. Crap.-

Oleg

Edit: The existing cache structure remains unchanged for now. It has an upside 
of being simple and functional and s downside of eviction policies being more 
complex and expensive to implement and the root cache entries being prone to 
getting out of sync with the cache content if some of its variants get dropped 
by the underlying cache storage.


was (Author: olegk):
>   Under our existing system architecture, we have yet to implement the Vary 
> header validation as specified in these requirements

[~arturobernalg] I have an unpleasant suspicion that that our entire internal 
cache structure is wrong. Presently it is a simple map of response objects 
keyed by the request URI and Vary headers. I suspect instead it should be a map 
of collections of request / response variants keyed by the request method and 
the request URI. It looks like we are looking at the complete redesign of the 
cache storage APIs and rewrite of the cache storage backends. Crap.

Oleg 

> HttpClient Cache conformance to RFC 9111
> ----------------------------------------
>
>                 Key: HTTPCLIENT-2277
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2277
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpCache
>            Reporter: Oleg Kalnichevski
>            Priority: Major
>          Time Spent: 14h
>  Remaining Estimate: 0h
>
> Ensure HttpClient Cache conforms to RFC 9111.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to